assembly of reconfigurator state should have limits #9197
+66
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this manually against Set the env variable based on the output above so I don't have to keep specifying it: Then I created a sequence of blueprints and made each successive one the target, like this: In the end I had this list: First, I'll export with the default pretty large limit: That got all of them, as expected. Then I'll export with a lower limit: That saved only the expected number, and only the most recent ones. I wanted to try the workflow of archiving in batches. So I started by archiving with limit 8: That file has the expected 8, including the current target, meaning it deleted 7: And they're gone: If we archive again, whatever the limit, we'll fetch them all and delete all but the current target: Again, we've got the latest 4, including the target and three that we deleted: and all but the target are gone now: Here's the history now: I think this is all working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards including Reconfigurator state in support bundles. I wanted callers to be able to cap how big these files could be so that the process doesn't take an unbounded amount of time or space. Then I realized that this also allows folks to use
omdb reconfigurator archiveto clean up enormous numbers of blueprints in batches by just re-running the tool with whatever limit they want.There are two things less than ideal about this:
I think this is all okay because:
omdb reconfigurator archiveregularly with each update, we should never have that many blueprints in a system that we care about. So we'll generally still be grabbing everything.I consider all of this sort of a stopgap. We really need to do #7278 so that support doesn't have to run tools to archive/prune old blueprints.